[AVRO-2872] 'conversions' array is not populated for Avro Union Logicaltype fields

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.9.2
• Fix Version/s: 1.13.0
• Component/s: logical types
• Labels: pull-request-available

Environment

• Apache Avro Version [1.9.2]
• Java Version [11]

• Assignee: Josh Cooke
• Reporter: Pádraig de Buitléar
• Created: 28/Jun/20 17:06
• Updated: 05/Aug/24 17:25

Description

Steps to reproduce :

1. Using the maven/gradle plugin generate code with the following avsc:
      

{
  "type": "record",
  "name": "Messages",
  "namespace": "com.somedomain",
  "fields": [
    {
      "name": "start",
      "type": {
        "type": "long",
        "logicalType": "timestamp-millis"
      }
    },
    {
      "name": "optional_date",
      "type": [
        "null",
        {
          "type": "long",
          "logicalType": "timestamp-millis"
        }
      ],
      "default": null
    }
  ]
}

 

Actual behavior
In the generated code, the return types of the getter methods for both fields are correct, however the conversions array only has an element for the field which isn't a union.
 

  private static final org.apache.avro.Conversion<?>[] conversions =
      new org.apache.avro.Conversion<?>[] {
      new org.apache.avro.data.TimeConversions.TimestampMillisConversion(),
      null,
      null
  };

 

Expected output:
Based on the above avsc the following is expected.
 

  private static final org.apache.avro.Conversion[] conversions =
      new org.apache.avro.Conversion[] {
      new org.apache.avro.data.TimeConversions.TimestampMillisConversion(),
      new org.apache.avro.data.TimeConversions.TimestampMillisConversion(),
      null
  };

 

 

 

Issue Links

• is related to: AVRO-3102 Avro Java IPC SpecificRequestor fails to convert union null + logical type fields
• is related to: AVRO-2840 Maven allow Custom Logical Types for generated code
• relates to: AVRO-2493 Unable to register Logical Type for custom Conversion class
• links to: GitHub Pull Request #1097