Avro
  1. Avro
  2. AVRO-284

Handle namespaces correctly in new Python implementation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0
    • Component/s: python
    • Labels:
      None

      Description

      Once AVRO-219 goes in, we should add unit tests and ensure that we handle namespaces as specified in AVRO-253.

      1. AVRO-284.patch.txt
        16 kB
        Patrick Wendell
      2. AVRO-284-v1.patch
        17 kB
        Jeff Hammerbacher
      3. AVRO-284-v2.patch
        6 kB
        Patrick Wendell

        Issue Links

          Activity

          Doug Cutting made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Jeff Hammerbacher made changes -
          Resolution Fixed [ 1 ]
          Status Reopened [ 4 ] Resolved [ 5 ]
          Hide
          Jeff Hammerbacher added a comment -

          Committed revision 955129 with the additional fixes.

          Show
          Jeff Hammerbacher added a comment - Committed revision 955129 with the additional fixes.
          Patrick Wendell made changes -
          Attachment AVRO-284-v2.patch [ 12447186 ]
          Hide
          Patrick Wendell added a comment -

          Hey Jeff think this addresses everything we talked about.

          Show
          Patrick Wendell added a comment - Hey Jeff think this addresses everything we talked about.
          Hide
          Jeff Hammerbacher added a comment -

          Todd set us up with a code review tool so we can pick through the exact issues. See http://review.hbase.org/r/166/ for the most recent version of the patch. Let's continue the discussion there.

          Show
          Jeff Hammerbacher added a comment - Todd set us up with a code review tool so we can pick through the exact issues. See http://review.hbase.org/r/166/ for the most recent version of the patch. Let's continue the discussion there.
          Jeff Hammerbacher made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Jeff Hammerbacher added a comment -

          Turns out this patch breaks schema printing. We need to maintain state about how a schema is created (e.g. which of name/namespace is set) and definitely not synthesize a property called "fullname". My apologies for the poor review, and for the poor test coverage which did not catch it.

          Show
          Jeff Hammerbacher added a comment - Turns out this patch breaks schema printing. We need to maintain state about how a schema is created (e.g. which of name/namespace is set) and definitely not synthesize a property called "fullname". My apologies for the poor review, and for the poor test coverage which did not catch it.
          Jeff Hammerbacher made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Jeff Hammerbacher added a comment -

          Committed to trunk with revision 953190.

          Show
          Jeff Hammerbacher added a comment - Committed to trunk with revision 953190.
          Jeff Hammerbacher made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jeff Hammerbacher made changes -
          Fix Version/s 1.4.0 [ 12314789 ]
          Jeff Hammerbacher made changes -
          Attachment AVRO-284-v1.patch [ 12446731 ]
          Hide
          Jeff Hammerbacher added a comment -

          Awesome work, Patrick! I cleaned up some of the comment styling and added a few extra tests, but this is ready to commit. Thanks again.

          Show
          Jeff Hammerbacher added a comment - Awesome work, Patrick! I cleaned up some of the comment styling and added a few extra tests, but this is ready to commit. Thanks again.
          Jeff Hammerbacher made changes -
          Assignee Jeff Hammerbacher [ hammer ] Patrick Wendell [ pwendell ]
          Patrick Wendell made changes -
          Attachment AVRO-284.patch.txt [ 12446610 ]
          Hide
          Patrick Wendell added a comment -

          This patch updates python implementation to include appropriate namespace logic. In particular, uses an implicit default namespace when full names are unspecified. Includes unit-tests.

          Show
          Patrick Wendell added a comment - This patch updates python implementation to include appropriate namespace logic. In particular, uses an implicit default namespace when full names are unspecified. Includes unit-tests.
          Jeff Hammerbacher made changes -
          Link This issue incorporates AVRO-253 [ AVRO-253 ]
          Jeff Hammerbacher made changes -
          Link This issue is blocked by AVRO-219 [ AVRO-219 ]
          Jeff Hammerbacher made changes -
          Field Original Value New Value
          Assignee Jeff Hammerbacher [ hammer ]
          Jeff Hammerbacher created issue -

            People

            • Assignee:
              Patrick Wendell
              Reporter:
              Jeff Hammerbacher
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development