[AVRO-2823] Can't find types if namespace has reserved word.

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: csharp
• Assignee: Unassigned
• Reporter: Rafael Merlin
• Created: 30/Apr/20 00:42
• Updated: 03/Jul/22 13:05

Description

Let's say I have this schema for my Values:

{
    "type": [{
            "type": "record",
            "name": "TestRecord",
            "namespace": "test.public.example",
            "fields": [{
                    "name": "name",
                    "type": "string"
                }, {
                    "name": "uuid",
                    "type": ["string", "null"]
                }
            ]
        }, {
            "type": "record",
            "name": "TestValue",
            "namespace": "test.public.example",
            "fields": [{
                    "name": "message_uuid",
                    "type": "string"
                }, {
                    "name": "trace_id",
                    "type": "string"
                }, {
                    "name": "testone",
                    "type": {
                        "type": "record",
                        "name": "TestOne",
                        "namespace": "test.public.example",
                        "fields": [{
                                "name": "uuid",
                                "type": "string"
                            }, {
                                "name": "message_number",
                                "type": "long"
                            }, {
                                "name": "name",
                                "type": "string"
                            }, {
                                "name": "internalarray",
                                "type": {
                                    "type": "array",
                                    "items": {
                                        "type": "record",
                                        "name": "InternalRecord",
                                        "namespace": "test.public.example",
                                        "fields": [{
                                                "name": "uuid",
                                                "type": "string"
                                            }, {
                                                "name": "generic_field",
                                                "type": "string"
                                            }
                                        ]
                                    }
                                }
                            }
                        ]
                    }
                }
            ]
        }
    ]
}

 

 

When I run avrogen the InternalRecord class will be generated as:

 

namespace [e-mail]
{
     public partial class InternalRecord : ISpecificRecord

 

 

However, when deserialising to this object (using the AvroDeserializer on ConsumerBuilder from Confluent.SchemaRegistry.Serdes.Avro.

 

When it gets to the Array the CodeGen step will eventually get to this method:

internal static string getType(Schema schema, bool nullible, ref bool nullibleEnum

 

And due to the schema's tag there being a Record it will hit this:

                case Schema.Type.Fixed:
                case Schema.Type.Record:
                case Schema.Type.Error:
                    namedSchema = schema as NamedSchema;
                    if (null == namedSchema)
                        throw new CodeGenException("Unable to cast schema into a named schema");
                    return CodeGenUtil.Instance.Mangle(namedSchema.Fullname);

This will Mangle the types again in here so now the type will be "[e-mail]" due to the Mangling. I reckon this may have been added due to protected names in properties or something like that. So a possible solution that I hope shouldn't affect anything else is to in the Object creator's FindType method to add this:

 

// Original Code:
if (diffAssembly)
{
    type = entryAssembly.GetType(name);
}// try current assembly and mscorlib
if (type == null)
{
    type = Type.GetType(name);
}

//Code to add to Original code.
if (name.Contains("@") && type == null)
{
    var unmangledName = CodeGenUtil.Instance.UnMangle(name);
    if (diffAssembly)
        type = entryAssembly.GetType(unmangledName);    
    if (type == null)
        type = Type.GetType(unmangledName);
}