Avro
  1. Avro
  2. AVRO-272

Extend RPCContext to include protocol Methods.

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: java
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since the RPCContext is used to send listeners/plugins handshake and call metadata, it makes sense to include the RPC method in it as well.

      1. AVRO-272.patch.txt
        3 kB
        Philip Zeyliger

        Issue Links

          Activity

          Philip Zeyliger created issue -
          Hide
          Philip Zeyliger added a comment -

          Attaching a patch. There's not much here. The two test lines do get invoked (I've set a breakpoint).

          It's possible I'm subverting AVRO-76 a bit. The plugin system seems to have been motivated in passing out of AVRO-band information between client and server. I'm using it to expose AVRO metadata to the client and server.

          (One possible way of exposing client host/port information to the server would be to write a plugin that sticks that information into thread locals, say. We'd still need to share the information between RPCContext and Transceiver, but that doesn't seem too bad.)

          Show
          Philip Zeyliger added a comment - Attaching a patch. There's not much here. The two test lines do get invoked (I've set a breakpoint). It's possible I'm subverting AVRO-76 a bit. The plugin system seems to have been motivated in passing out of AVRO-band information between client and server. I'm using it to expose AVRO metadata to the client and server. (One possible way of exposing client host/port information to the server would be to write a plugin that sticks that information into thread locals, say. We'd still need to share the information between RPCContext and Transceiver, but that doesn't seem too bad.)
          Philip Zeyliger made changes -
          Field Original Value New Value
          Attachment AVRO-272.patch.txt [ 12429171 ]
          Philip Zeyliger made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Philip Zeyliger made changes -
          Link This issue is part of AVRO-270 [ AVRO-270 ]
          Hide
          Doug Cutting added a comment -

          I just committed this.

          I think it might make sense to add a method like:

          public static RPCContext Responder#getContext()

          that can be called within a protocol implementation and retrieves the context from a ThreadLocal.

          Show
          Doug Cutting added a comment - I just committed this. I think it might make sense to add a method like: public static RPCContext Responder#getContext() that can be called within a protocol implementation and retrieves the context from a ThreadLocal.
          Doug Cutting made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 1.3.0 [ 12314318 ]
          Resolution Fixed [ 1 ]
          Doug Cutting made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          21m 33s 1 Philip Zeyliger 30/Dec/09 21:02
          Patch Available Patch Available Resolved Resolved
          21h 49m 1 Doug Cutting 31/Dec/09 18:51
          Resolved Resolved Closed Closed
          59d 22h 17m 1 Doug Cutting 01/Mar/10 17:09

            People

            • Assignee:
              Philip Zeyliger
              Reporter:
              Philip Zeyliger
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development