[AVRO-2692] Do Not Access Map Twice in LogicalTypes

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 17/Jan/20 16:08
• Updated: 02/Jul/20 12:23
• Resolved: 19/Feb/20 08:42

Description

https://github.com/apache/avro/blob/84b056c2adc069cf31f3b4d3c9337cb7cdaa58d6/lang/java/avro/src/main/java/org/apache/avro/LogicalTypes.java#L102-L107

LogicalTypes.java

        final LogicalTypeFactory typeFactory = REGISTERED_TYPES.get(typeName);
        if (typeFactory != null) {
          logicalType = REGISTERED_TYPES.get(typeName).fromSchema(schema);
        } else {
          logicalType = null;
        }

The typeFactory is already obtained from the map on the first line, no need to go back to the map again to get it.

Issue Links

• links to: GitHub Pull Request #772