Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-2593

test_tether_word_counts errors obscured

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.9.1
    • 1.9.2
    • python
    • None

    Description

      lang/py/test/test_tether_word_count.py is somewhat fragile. When it fails, the true failure is obscured by a secondary error because exfile is first defined on line 179 and may not even exist in the finally block.

      I propose a significant refactor of this test to make the results clearer and to adhere to more idiomatic testing and python by:

      1. Isolating the main test from its setup and teardown using standard setUp and tearDown.
      2. Isolating the subprocess try/finally from the entire test setup/teardown.
      3. Avoid having to manage multiple temporary files by running the entire test in a temporary directory.

      Attachments

        Activity

          People

            kojiromike Michael A. Smith
            kojiromike Michael A. Smith
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: