[AVRO-2356] GenericDatumWriter.write must require encoder to be not null

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.9.0
• Component/s: java
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 22/Mar/19 14:05
• Updated: 28/Mar/19 09:40
• Resolved: 28/Mar/19 09:16

Description

I was recently doing some debugging and writing tests for Avro and I received the following stack trace:

java.lang.NullPointerException: null of E in field f of R
	at org.apache.avro.generic.GenericDatumWriter.npe(GenericDatumWriter.java:147)
	at org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:141)
	at org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:77)
	at org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:64)

That took me quite awhile to decipher. How about me Avro a library for laypeople. I propose:

java.lang.NullPointerException: Encoder cannot be null
	at java.util.Objects.requireNonNull(Objects.java:228)
	at org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:63)
	at org.apache.avro.test.basic.ExtendedEnumPerf.encode(ExtendedEnumPerf.java:26)

Issue Links

• links to: GitHub Pull Request #489