[AVRO-2245] Java codec testing improvements

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.9.0
• Component/s: java
• Assignee: Jacob Tolar
• Reporter: Jacob Tolar
• Created: 18/Oct/18 16:45
• Updated: 21/May/20 14:17
• Resolved: 08/Nov/18 16:12

Description

In the Avro Java implementation, TestBZip2Codec and TestZstandardCodec are both laughably wrong.

For example, the last lines of TestBZip2Codec:

byte[] outputByteArray = decompressedBuffer.array();
for (int i = 0; i < inputByteSize; i++) {
  inputByteArray[i] = outputByteArray[i];
}

There should be an assertEquals in there not an assignment statement. (And if you put assertEquals there, the test actually fails...).

I will send a PR that replaces these tests with a correct parametrized test for all codecs.

Issue Links

• links to: GitHub Pull Request #351