[AVRO-2056] DirectBinaryEncoder Creates Buffer For Each Call To writeDouble

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7.7, 1.8.2
• Fix Version/s: 1.9.0
• Component/s: java
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 18/Jul/17 20:20
• Updated: 28/Jul/17 07:19
• Resolved: 28/Jul/17 07:19

Description

Each call to writeDouble creates a new buffer and promptly throws it away even though the class has a re-usable buffer and is used in other methods such as writeFloat. Remove this extra buffer.

org.apache.avro.io.DirectBinaryEncoder

  // the buffer is used for writing floats, doubles, and large longs.
  private final byte[] buf = new byte[12];

  @Override
  public void writeFloat(float f) throws IOException {
    int len = BinaryData.encodeFloat(f, buf, 0);
    out.write(buf, 0, len);
  }

  @Override
  public void writeDouble(double d) throws IOException {
    byte[] buf = new byte[8];
    int len = BinaryData.encodeDouble(d, buf, 0);
    out.write(buf, 0, len);
  }