Uploaded image for project: 'Avro'
  1. Avro
  2. AVRO-2055

Remove Magic Value From org.apache.avro.hadoop.io.AvroSequenceFile

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.7.7, 1.8.2
    • Fix Version/s: 1.9.0
    • Component/s: java
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Flags:
      Patch

      Description

      Remove magic string io.file.buffer.size and DEFAULT_BUFFER_SIZE_BYTES and instead rely on the Hadoop libraries to provide this information. Will help to keep Avro in sync with changes in Hadoop.

        Issue Links

          Activity

          Hide
          sacharya Suraj Acharya added a comment -

          +1.
          LGTM

          Show
          sacharya Suraj Acharya added a comment - +1. LGTM
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 1s The patch does not contain any @author tags.
          +1 buildtest 0m 0s master passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 buildtest 6m 35s the patch passed
          6m 50s



          Subsystem Report/Notes
          Docker Client=1.13.1 Server=1.13.1 Image:yetus/avro:793178a
          JIRA Issue AVRO-2055
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877868/AVRO-2055.1.patch
          Optional Tests buildtest javac
          uname Linux 7f5310dc7da6 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 GNU/Linux
          Build tool build
          git revision master / 793178a
          Default Java 1.7.0_111
          modules C: lang/java U: lang/java
          Console output https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/33/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 buildtest 0m 0s master passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 buildtest 6m 35s the patch passed 6m 50s Subsystem Report/Notes Docker Client=1.13.1 Server=1.13.1 Image:yetus/avro:793178a JIRA Issue AVRO-2055 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877868/AVRO-2055.1.patch Optional Tests buildtest javac uname Linux 7f5310dc7da6 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 GNU/Linux Build tool build git revision master / 793178a Default Java 1.7.0_111 modules C: lang/java U: lang/java Console output https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/33/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          gszadovszky Gabor Szadovszky added a comment -

          +1

          Show
          gszadovszky Gabor Szadovszky added a comment - +1
          Hide
          gszadovszky Gabor Szadovszky added a comment -

          BELUGA BEHR, sorry I've just realised during doing a build with your patches that we are in the same situation than with AVRO-2053. It does not even compile as we are using hadoop-1 by default. So, let's wait if we can get rid of Hadoop 1 in 1.9.

          Show
          gszadovszky Gabor Szadovszky added a comment - BELUGA BEHR , sorry I've just realised during doing a build with your patches that we are in the same situation than with AVRO-2053 . It does not even compile as we are using hadoop-1 by default. So, let's wait if we can get rid of Hadoop 1 in 1.9.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9f3ceefda1ee31c388f535a8d3007f0749119447 in avro's branch refs/heads/master from BELUGA BEHR
          [ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=9f3ceef ]

          AVRO-2055: Remove Magic Value From org.apache.avro.hadoop.io.AvroSequenceFile

          Signed-off-by: sacharya <suraj@apache.org>
          Signed-off-by: Gabor Szadovszky <gabor@apache.org>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9f3ceefda1ee31c388f535a8d3007f0749119447 in avro's branch refs/heads/master from BELUGA BEHR [ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=9f3ceef ] AVRO-2055 : Remove Magic Value From org.apache.avro.hadoop.io.AvroSequenceFile Signed-off-by: sacharya <suraj@apache.org> Signed-off-by: Gabor Szadovszky <gabor@apache.org>

            People

            • Assignee:
              belugabehr BELUGA BEHR
              Reporter:
              belugabehr BELUGA BEHR
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development