Avro
  1. Avro
  2. AVRO-203

Add single space between "#" and text in license headers for Python files

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: python
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      According to PEP 8 (http://www.python.org/dev/peps/pep-0008/), "Each line of a block comment starts with a # and a single space (unless it is indented text inside the comment)."

      1. AVRO-203.patch
        25 kB
        Jeff Hammerbacher

        Activity

        Jeff Hammerbacher created issue -
        Jeff Hammerbacher made changes -
        Field Original Value New Value
        Attachment AVRO-203.patch [ 12425056 ]
        Jeff Hammerbacher made changes -
        Assignee Jeff Hammerbacher [ hammer ]
        Jeff Hammerbacher made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Patrick Hunt added a comment -

        +1, this patch looks good to me, ready for commit.

        Show
        Patrick Hunt added a comment - +1, this patch looks good to me, ready for commit.
        Patrick Hunt made changes -
        Hadoop Flags [Reviewed]
        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Jeff.

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Jeff.
        Doug Cutting made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 1.3.0 [ 12314318 ]
        Resolution Fixed [ 1 ]
        Hide
        Doug Cutting added a comment -

        The "Task" issue type is rarely used. It's for stuff like account creation, things that aren't patches.

        Show
        Doug Cutting added a comment - The "Task" issue type is rarely used. It's for stuff like account creation, things that aren't patches.
        Doug Cutting made changes -
        Issue Type Task [ 3 ] Improvement [ 4 ]
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        2d 10h 39m 1 Jeff Hammerbacher 18/Nov/09 22:24
        Patch Available Patch Available Resolved Resolved
        2h 25m 1 Doug Cutting 19/Nov/09 00:49
        Resolved Resolved Closed Closed
        102d 16h 19m 1 Doug Cutting 01/Mar/10 17:09

          People

          • Assignee:
            Jeff Hammerbacher
            Reporter:
            Jeff Hammerbacher
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development