Avro
  1. Avro
  2. AVRO-203

Add single space between "#" and text in license headers for Python files

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: python
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      According to PEP 8 (http://www.python.org/dev/peps/pep-0008/), "Each line of a block comment starts with a # and a single space (unless it is indented text inside the comment)."

      1. AVRO-203.patch
        25 kB
        Jeff Hammerbacher

        Activity

        Hide
        Patrick Hunt added a comment -

        +1, this patch looks good to me, ready for commit.

        Show
        Patrick Hunt added a comment - +1, this patch looks good to me, ready for commit.
        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Jeff.

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Jeff.
        Hide
        Doug Cutting added a comment -

        The "Task" issue type is rarely used. It's for stuff like account creation, things that aren't patches.

        Show
        Doug Cutting added a comment - The "Task" issue type is rarely used. It's for stuff like account creation, things that aren't patches.

          People

          • Assignee:
            Jeff Hammerbacher
            Reporter:
            Jeff Hammerbacher
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development