Avro
  1. Avro
  2. AVRO-193

"ant test-avroj" fails on Ubuntu 9.10

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      Ubuntu 9.10

      Description

      "ant test-avroj" fails because mktemp's template in src/test/bin/test_avroj.sh does not have Xs. The accompanying patch fixes it.

      1. AVRO-193.patch
        0.5 kB
        Thiruvalluvan M. G.
      2. AVRO-193.patch
        2 kB
        Doug Cutting

        Activity

        Thiruvalluvan M. G. created issue -
        Thiruvalluvan M. G. made changes -
        Field Original Value New Value
        Attachment AVRO-193.patch [ 12424706 ]
        Thiruvalluvan M. G. made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Doug Cutting added a comment -

        Thanks for finding this, Thiru! Your patch works for me.

        However we've sometimes had trouble in the past when using /tmp. Might it be better to use build/test like the other tests?

        Also, it would be safest to pass paths down from ant.

        Plus, it will make things easier to debug if the test output directory remains. So we should remove it before the tests, to start with a clean slate, and leave it after, since it's in build/ and will be removed by 'ant clean'.

        And finally, it's redundant to both echo every line and echo informative messages.

        Here's a new version that addresses all of these.

        Show
        Doug Cutting added a comment - Thanks for finding this, Thiru! Your patch works for me. However we've sometimes had trouble in the past when using /tmp. Might it be better to use build/test like the other tests? Also, it would be safest to pass paths down from ant. Plus, it will make things easier to debug if the test output directory remains. So we should remove it before the tests, to start with a clean slate, and leave it after, since it's in build/ and will be removed by 'ant clean'. And finally, it's redundant to both echo every line and echo informative messages. Here's a new version that addresses all of these.
        Doug Cutting made changes -
        Attachment AVRO-193.patch [ 12424731 ]
        Hide
        Philip Zeyliger added a comment -

        +1 on Doug's patch.

        Show
        Philip Zeyliger added a comment - +1 on Doug's patch.
        Hide
        Doug Cutting added a comment -

        I just committed this.

        Show
        Doug Cutting added a comment - I just committed this.
        Doug Cutting made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 1.3.0 [ 12314318 ]
        Resolution Fixed [ 1 ]
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Doug Cutting made changes -
        Component/s build [ 12313242 ]

          People

          • Assignee:
            Thiruvalluvan M. G.
            Reporter:
            Thiruvalluvan M. G.
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development