[AVRO-1698] cant serialize json with characters >127 when compiling with signed char

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.7.7
• Component/s: c++

Environment

windows, linux w signed char

• Assignee: Unassigned
• Reporter: svante karlsson
• Created: 09/Jul/15 15:12
• Updated: 29/Dec/18 18:36
• Resolved: 29/Dec/18 18:36

Description

iscntrl assumes 0-255 but signed char gets expanded to bad things

pullreq #38 on github solves the issue.

change line 196 lang/c++/impl/json/JsonIO.hh
from
if (! iscntrl(*p)) {
to
if (! iscntrl((uint8_t) *p)) {

Issue Links

• duplicates: AVRO-1190 C++ json parser fails to decode multibyte unicode code points