Avro
  1. Avro
  2. AVRO-167

Refactor of SpecificCompiler to facilitate easier testing

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: java
    • Labels:
      None

      Description

      Originally part of AVRO-152, the patch that follows has SpecificCompiler write to Strings; it writes those strings to files separately. The motivation behind this was to be able to look at the generated file contents without dealing with files.

      This patch also adds tests for some of the helper methods, adds tests that a few schemas generate code fine, and adds a line in TestSchema that makes sure that every schema that test sees can generate code just fine.

      1. AVRO-167.patch.txt
        19 kB
        Philip Zeyliger

        Activity

        Hide
        Doug Cutting added a comment -

        I just committed this. I changed a few places where code exceeded 80 columns. Thanks, Philip.

        Show
        Doug Cutting added a comment - I just committed this. I changed a few places where code exceeded 80 columns. Thanks, Philip.

          People

          • Assignee:
            Philip Zeyliger
            Reporter:
            Philip Zeyliger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development