Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-166

Minor refactoring of Schema.java to better error reporting on bad schemas.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.3.0
    • java
    • None

    Description

      Originally part of AVRO-152, this introduces getStringOptional and getStringRequired helper methods, to facilitate throwing meaningful exceptions when something's wrong with a schema.

      There aren't tests that bad schemas fail the validation in the expected ways, but this did trigger a test which had a fixed field of size 0, which makes no sense; that has been fixed.

      Where it was immediately adjacent, I've fixed brace-less if's according to the style guide (http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#449).

      Attachments

        1. AVRO-166.patch.txt
          5 kB
          Philip Martin

        Activity

          People

            philip Philip Martin
            philip Philip Martin
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: