Avro
  1. Avro
  2. AVRO-166

Minor refactoring of Schema.java to better error reporting on bad schemas.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: java
    • Labels:
      None

      Description

      Originally part of AVRO-152, this introduces getStringOptional and getStringRequired helper methods, to facilitate throwing meaningful exceptions when something's wrong with a schema.

      There aren't tests that bad schemas fail the validation in the expected ways, but this did trigger a test which had a fixed field of size 0, which makes no sense; that has been fixed.

      Where it was immediately adjacent, I've fixed brace-less if's according to the style guide (http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#449).

      1. AVRO-166.patch.txt
        5 kB
        Philip Zeyliger

        Activity

        Hide
        Philip Zeyliger added a comment -

        Attaching patch.

        Show
        Philip Zeyliger added a comment - Attaching patch.
        Hide
        Doug Cutting added a comment -

        I just committed this. I reverted some gratuitous style changes in the patch. Thanks, Philip!

        Show
        Doug Cutting added a comment - I just committed this. I reverted some gratuitous style changes in the patch. Thanks, Philip!

          People

          • Assignee:
            Philip Zeyliger
            Reporter:
            Philip Zeyliger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development