Avro
  1. Avro
  2. AVRO-165

TestReflect has a bug in its equals method.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: java
    • Labels:
      None

      Description

      Eclipse pointed out an unused variable, which turned out to be a bad equals implementation. Patch to follow. (This is part of a split up of AVRO-152).

      1. AVRO-165.patch.txt
        1 kB
        Philip Zeyliger

        Activity

        Hide
        Philip Zeyliger added a comment -

        I think this is more right. This is test code (so it doesn't get separately tested), and didn't trigger any real failure, but no reason to keep bad equals() implementations around.

        Show
        Philip Zeyliger added a comment - I think this is more right. This is test code (so it doesn't get separately tested), and didn't trigger any real failure, but no reason to keep bad equals() implementations around.
        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Philip!

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Philip!

          People

          • Assignee:
            Philip Zeyliger
            Reporter:
            Philip Zeyliger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development