Avro
  1. Avro
  2. AVRO-165

TestReflect has a bug in its equals method.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: java
    • Labels:
      None

      Description

      Eclipse pointed out an unused variable, which turned out to be a bad equals implementation. Patch to follow. (This is part of a split up of AVRO-152).

      1. AVRO-165.patch.txt
        1 kB
        Philip Zeyliger

        Activity

        Philip Zeyliger created issue -
        Hide
        Philip Zeyliger added a comment -

        I think this is more right. This is test code (so it doesn't get separately tested), and didn't trigger any real failure, but no reason to keep bad equals() implementations around.

        Show
        Philip Zeyliger added a comment - I think this is more right. This is test code (so it doesn't get separately tested), and didn't trigger any real failure, but no reason to keep bad equals() implementations around.
        Philip Zeyliger made changes -
        Field Original Value New Value
        Attachment AVRO-165.patch.txt [ 12422769 ]
        Philip Zeyliger made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Doug Cutting made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Philip!

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Philip!
        Doug Cutting made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 1.2.1 [ 12314317 ]
        Resolution Fixed [ 1 ]
        Doug Cutting made changes -
        Fix Version/s 1.3.0 [ 12314318 ]
        Fix Version/s 1.2.1 [ 12314317 ]
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        42m 21s 1 Philip Zeyliger 21/Oct/09 07:09
        Patch Available Patch Available Resolved Resolved
        10h 38m 1 Doug Cutting 21/Oct/09 17:47
        Resolved Resolved Closed Closed
        131d 21m 1 Doug Cutting 01/Mar/10 17:09

          People

          • Assignee:
            Philip Zeyliger
            Reporter:
            Philip Zeyliger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development