Avro
  1. Avro
  2. AVRO-164

Generate paranamer metadata for interfaces as part of SpecificCompiler

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: java
    • Labels:
      None

      Description

      As discussed a bit in AVRO-146, we shouldn't need to run paranamer in a separate build step if we have all the schema information already. We could keep the code paths the same across the reflected and specific use cases by simply generating the necessary paranamer variable in SpecificCompiler.

        Issue Links

          Activity

          Hide
          Doug Cutting added a comment -

          AVRO-185 fixes this by adding the protocol to generated interfaces.

          After that's committed, Paranamer will only needed for reflection, where method parameter names are unknown. If we wanted to remove paranamer even there, then I suppose we could simply name parameters by their type, e.g., foo(String title, String body) would become foo(String string1, String string2).

          Show
          Doug Cutting added a comment - AVRO-185 fixes this by adding the protocol to generated interfaces. After that's committed, Paranamer will only needed for reflection, where method parameter names are unknown. If we wanted to remove paranamer even there, then I suppose we could simply name parameters by their type, e.g., foo(String title, String body) would become foo(String string1, String string2).
          Hide
          Doug Cutting added a comment -

          The fix for this was included in AVRO-185.

          Show
          Doug Cutting added a comment - The fix for this was included in AVRO-185 .

            People

            • Assignee:
              Doug Cutting
              Reporter:
              Philip Zeyliger
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development