Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-1560

SNAPPY_INCLUDE_DIR not accounted in CMakeLists.txt

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.7.7
    • 1.8.0
    • c

    Description

      The current CMakeLists.txt does not account for Snappy include folders causing the compilation to fail when a custom snappy location is provided using -DSNAPPY_ROOT_DIR

      e.g .

      cmake avro-c-1.7.7 -DSNAPPY_ROOT_DIR=${SNAPPY_INSTALL_DIR}
      

      In https://github.com/apache/avro/blob/release-1.7.7/lang/c/CMakeLists.txt#L143 we should include

      include_directories(${SNAPPY_INCLUDE_DIR})
      

      Attachments

        1. AVRO-1560.patch
          0.5 kB
          Ujjwal

        Activity

          People

            Unassigned Unassigned
            ujjwal.wadhawan Ujjwal
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified