Avro
  1. Avro
  2. AVRO-148

Add ant target to build c++ project

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: c++
    • Labels:
      None

      Description

      I have a preliminary patch for this, but it has a dependency on AVRO-147, so I'm waiting to commit that before posting this.

      1. AVRO-148.patch
        22 kB
        Scott Banachowski
      2. AVR0-148.patch
        28 kB
        Scott Banachowski
      3. applypatch148.sh
        0.1 kB
        Scott Banachowski

        Activity

        Scott Banachowski created issue -
        Scott Banachowski made changes -
        Field Original Value New Value
        Assignee Scott Banachowski [ sbanacho ]
        Hide
        Scott Banachowski added a comment -

        Here's a change that allows the ant build to include cpp stuff now.

        There's a patch, and a shell to apply the patch (one file got renamed, hence the shell).

        All the cpp targets work ok for me on linux and mac. I'm curious if it'll work for others.

        I haven't been able to do a full ant build because of the java stuff is not working for me (do we need to have both java5 and 6 installed to work?)

        Show
        Scott Banachowski added a comment - Here's a change that allows the ant build to include cpp stuff now. There's a patch, and a shell to apply the patch (one file got renamed, hence the shell). All the cpp targets work ok for me on linux and mac. I'm curious if it'll work for others. I haven't been able to do a full ant build because of the java stuff is not working for me (do we need to have both java5 and 6 installed to work?)
        Scott Banachowski made changes -
        Attachment AVRO-148.patch [ 12422306 ]
        Attachment applypatch148.sh [ 12422307 ]
        Scott Banachowski made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Doug Cutting added a comment -

        +1 This integration is great to have!

        The only nit I have is that the c++ docs should be linked into the rest of the docs, by adding a link in src/doc/content/xdocs/site.xml.

        You need to have Java 5 installed to build the documentation, since Forrest requires it. (Sigh.)

        I have the following in ~/build.properties to make Forrest work for me in all Hadoop projects and sites:

        java5.home=/home/cutting/local/java-1.5.0-sun
        forrest.home=/home/cutting/local/forrest
        
        Show
        Doug Cutting added a comment - +1 This integration is great to have! The only nit I have is that the c++ docs should be linked into the rest of the docs, by adding a link in src/doc/content/xdocs/site.xml. You need to have Java 5 installed to build the documentation, since Forrest requires it. (Sigh.) I have the following in ~/build.properties to make Forrest work for me in all Hadoop projects and sites: java5.home=/home/cutting/local/java-1.5.0-sun forrest.home=/home/cutting/local/forrest
        Hide
        Scott Banachowski added a comment -

        revised patch, adds c++ docs to site.xml

        Show
        Scott Banachowski added a comment - revised patch, adds c++ docs to site.xml
        Scott Banachowski made changes -
        Attachment AVRO-148.patch [ 12422601 ]
        Scott Banachowski made changes -
        Attachment AVR0-148.patch [ 12422603 ]
        Scott Banachowski made changes -
        Attachment AVRO-148.patch [ 12422601 ]
        Hide
        Doug Cutting added a comment -

        +1 Looks great to me!

        Show
        Doug Cutting added a comment - +1 Looks great to me!
        Hide
        Scott Banachowski added a comment -

        Thanks for testing. I committed revision 827822.

        Show
        Scott Banachowski added a comment - Thanks for testing. I committed revision 827822.
        Scott Banachowski made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Doug Cutting made changes -
        Fix Version/s 1.3.0 [ 12314318 ]
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1d 22h 39m 1 Scott Banachowski 16/Oct/09 01:06
        Patch Available Patch Available Resolved Resolved
        4d 22h 25m 1 Scott Banachowski 20/Oct/09 23:32
        Resolved Resolved Closed Closed
        131d 18h 36m 1 Doug Cutting 01/Mar/10 17:09

          People

          • Assignee:
            Scott Banachowski
            Reporter:
            Scott Banachowski
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development