Uploaded image for project: 'Avro'
  1. Avro
  2. AVRO-148

Add ant target to build c++ project

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: c++
    • Labels:
      None

      Description

      I have a preliminary patch for this, but it has a dependency on AVRO-147, so I'm waiting to commit that before posting this.

      1. applypatch148.sh
        0.1 kB
        Scott Banachowski
      2. AVR0-148.patch
        28 kB
        Scott Banachowski
      3. AVRO-148.patch
        22 kB
        Scott Banachowski

        Activity

        Hide
        sbanacho Scott Banachowski added a comment -

        Thanks for testing. I committed revision 827822.

        Show
        sbanacho Scott Banachowski added a comment - Thanks for testing. I committed revision 827822.
        Hide
        cutting Doug Cutting added a comment -

        +1 Looks great to me!

        Show
        cutting Doug Cutting added a comment - +1 Looks great to me!
        Hide
        sbanacho Scott Banachowski added a comment -

        revised patch, adds c++ docs to site.xml

        Show
        sbanacho Scott Banachowski added a comment - revised patch, adds c++ docs to site.xml
        Hide
        cutting Doug Cutting added a comment -

        +1 This integration is great to have!

        The only nit I have is that the c++ docs should be linked into the rest of the docs, by adding a link in src/doc/content/xdocs/site.xml.

        You need to have Java 5 installed to build the documentation, since Forrest requires it. (Sigh.)

        I have the following in ~/build.properties to make Forrest work for me in all Hadoop projects and sites:

        java5.home=/home/cutting/local/java-1.5.0-sun
        forrest.home=/home/cutting/local/forrest
        
        Show
        cutting Doug Cutting added a comment - +1 This integration is great to have! The only nit I have is that the c++ docs should be linked into the rest of the docs, by adding a link in src/doc/content/xdocs/site.xml. You need to have Java 5 installed to build the documentation, since Forrest requires it. (Sigh.) I have the following in ~/build.properties to make Forrest work for me in all Hadoop projects and sites: java5.home=/home/cutting/local/java-1.5.0-sun forrest.home=/home/cutting/local/forrest
        Hide
        sbanacho Scott Banachowski added a comment -

        Here's a change that allows the ant build to include cpp stuff now.

        There's a patch, and a shell to apply the patch (one file got renamed, hence the shell).

        All the cpp targets work ok for me on linux and mac. I'm curious if it'll work for others.

        I haven't been able to do a full ant build because of the java stuff is not working for me (do we need to have both java5 and 6 installed to work?)

        Show
        sbanacho Scott Banachowski added a comment - Here's a change that allows the ant build to include cpp stuff now. There's a patch, and a shell to apply the patch (one file got renamed, hence the shell). All the cpp targets work ok for me on linux and mac. I'm curious if it'll work for others. I haven't been able to do a full ant build because of the java stuff is not working for me (do we need to have both java5 and 6 installed to work?)

          People

          • Assignee:
            sbanacho Scott Banachowski
            Reporter:
            sbanacho Scott Banachowski
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development