Avro
  1. Avro
  2. AVRO-1459

'gem install avro' does not work for version 1.7.6

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.6
    • Fix Version/s: 1.7.7
    • Component/s: ruby
    • Labels:
      None

      Description

      When trying to install 'gem install avro' it fails with error "ERROR: Could not find a valid gem 'multi-json' (>= 0) in any repository" .

      This was introduced by AVRO-1063 where multi-json dependency was introduced. The correct way of spelling that seems to be 'multi_json'.

      1. AVRO-1459.patch
        0.4 kB
        Tomas Svarovsky

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          10m 39s 1 Tomas Svarovsky 15/Feb/14 21:29
          Patch Available Patch Available Resolved Resolved
          25d 23h 14m 1 Doug Cutting 13/Mar/14 20:44
          Resolved Resolved Closed Closed
          132d 23h 32m 1 Doug Cutting 24/Jul/14 21:16
          Doug Cutting made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Sean Busbey made changes -
          Link This issue is broken by AVRO-1063 [ AVRO-1063 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in AvroJava #446 (See https://builds.apache.org/job/AvroJava/446/)
          AVRO-1459. Ruby: Fix a typo in Rakefile that breaks 'gem install'. Contributed by Tomas Svarovsky. (cutting: rev 1577311)

          • /avro/trunk/CHANGES.txt
          • /avro/trunk/lang/ruby/Rakefile
          Show
          Hudson added a comment - SUCCESS: Integrated in AvroJava #446 (See https://builds.apache.org/job/AvroJava/446/ ) AVRO-1459 . Ruby: Fix a typo in Rakefile that breaks 'gem install'. Contributed by Tomas Svarovsky. (cutting: rev 1577311) /avro/trunk/CHANGES.txt /avro/trunk/lang/ruby/Rakefile
          Doug Cutting made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Assignee Tomas Svarovsky [ fluke777 ]
          Resolution Fixed [ 1 ]
          Hide
          Doug Cutting added a comment -

          I committed this. Thanks, Tomas.

          Show
          Doug Cutting added a comment - I committed this. Thanks, Tomas.
          Hide
          ASF subversion and git services added a comment -

          Commit 1577311 from Doug Cutting in branch 'avro/trunk'
          [ https://svn.apache.org/r1577311 ]

          AVRO-1459. Ruby: Fix a typo in Rakefile that breaks 'gem install'. Contributed by Tomas Svarovsky.

          Show
          ASF subversion and git services added a comment - Commit 1577311 from Doug Cutting in branch 'avro/trunk' [ https://svn.apache.org/r1577311 ] AVRO-1459 . Ruby: Fix a typo in Rakefile that breaks 'gem install'. Contributed by Tomas Svarovsky.
          Hide
          Rafer Hazen added a comment -

          +1 for this patch. We've had to apply this patch locally to use the the avro gem in JRuby (for MRI we've been able to stay at the 1.7.5 patch level, which uses yajl, to avoid this issue).

          Show
          Rafer Hazen added a comment - +1 for this patch. We've had to apply this patch locally to use the the avro gem in JRuby (for MRI we've been able to stay at the 1.7.5 patch level, which uses yajl, to avoid this issue).
          Sean Busbey made changes -
          Fix Version/s 1.7.7 [ 12326041 ]
          Hide
          Sean Busbey added a comment -

          Unfortunately, I don't think the project currently has a primary Ruby maintainer. I believe there was talk on AVRO-1063 about improving the gem building process. There's supposed to be a follow on ticket; you should pitch in on that.

          WRT this patch, +1 (non-binding) lgtm.

          Show
          Sean Busbey added a comment - Unfortunately, I don't think the project currently has a primary Ruby maintainer. I believe there was talk on AVRO-1063 about improving the gem building process. There's supposed to be a follow on ticket; you should pitch in on that. WRT this patch, +1 (non-binding) lgtm.
          Hide
          Tomas Svarovsky added a comment -

          I would like to use it in the future so I am willing to help but seems like the topic of building gems is an area where everybody does it a little bit differently (and I cannot claim I am ruby master). Who is current Ruby maintainer? Maybe we can get more info from him?

          Show
          Tomas Svarovsky added a comment - I would like to use it in the future so I am willing to help but seems like the topic of building gems is an area where everybody does it a little bit differently (and I cannot claim I am ruby master). Who is current Ruby maintainer? Maybe we can get more info from him?
          Hide
          Sean Busbey added a comment -

          Is there a specific reason why there are 2 different ways how to specify dependencies?

          Probably just that the project doesn't have enough Ruby people looking at the code. (For example: I'm a jruby user, so historically I've always just wrapped the java library since AVRO-1063 meant I couldn't use the gem)

          Show
          Sean Busbey added a comment - Is there a specific reason why there are 2 different ways how to specify dependencies? Probably just that the project doesn't have enough Ruby people looking at the code. (For example: I'm a jruby user, so historically I've always just wrapped the java library since AVRO-1063 meant I couldn't use the gem)
          Hide
          Tomas Svarovsky added a comment -

          Hey Sean

          yeah rvm 1.24.7, ruby, ruby-1.9.3-p429.

          I did not look into the tests but my expectation would be, that installation is not covered by tests. When I searched the archive it seems like testing infrastructure is leveraging Gemfile, not rake which is (maybe/probably?) used for generating the actual gem.

          If you look at Gemfile you can see that multi_json is spelled there correctly which would explain why it does not fail during set up of the testing environment. Is there a specific reason why there are 2 different ways how to specify dependencies?

          Tomas

          Show
          Tomas Svarovsky added a comment - Hey Sean yeah rvm 1.24.7, ruby, ruby-1.9.3-p429. I did not look into the tests but my expectation would be, that installation is not covered by tests. When I searched the archive it seems like testing infrastructure is leveraging Gemfile, not rake which is (maybe/probably?) used for generating the actual gem. If you look at Gemfile you can see that multi_json is spelled there correctly which would explain why it does not fail during set up of the testing environment. Is there a specific reason why there are 2 different ways how to specify dependencies? Tomas
          Hide
          Sean Busbey added a comment -

          What version of ruby / gems are you using? Is it an RVM installation?

          I'd like to chase down what the difference was from the testing on AVRO-1063.

          Show
          Sean Busbey added a comment - What version of ruby / gems are you using? Is it an RVM installation? I'd like to chase down what the difference was from the testing on AVRO-1063 .
          Tomas Svarovsky made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Tomas Svarovsky made changes -
          Field Original Value New Value
          Attachment AVRO-1459.patch [ 12629239 ]
          Tomas Svarovsky created issue -

            People

            • Assignee:
              Tomas Svarovsky
              Reporter:
              Tomas Svarovsky
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development