Avro
  1. Avro
  2. AVRO-1446

System errors not supported in RPC

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7.6
    • Fix Version/s: 1.7.7
    • Component/s: csharp
    • Labels:
      None

      Description

      System (string) errors are not proper handled in the C# RPC implementation and the system error information is lost as a different exception is raised.

        Activity

        David Taylor created issue -
        Hide
        David Taylor added a comment -

        Suggested patch attached including new test case.

        Show
        David Taylor added a comment - Suggested patch attached including new test case.
        David Taylor made changes -
        Field Original Value New Value
        Attachment system-error-fix.diff [ 12625116 ]
        Hide
        Doug Cutting added a comment -

        Looks good to me & tests pass. +1

        I'll commit this soon unless there are objections.

        Show
        Doug Cutting added a comment - Looks good to me & tests pass. +1 I'll commit this soon unless there are objections.
        Doug Cutting made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee David Taylor [ davidtaylor ]
        Fix Version/s 1.7.7 [ 12326041 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1561874 from Doug Cutting in branch 'avro/trunk'
        [ https://svn.apache.org/r1561874 ]

        AVRO-1446. C#: Correctly handle system errors in RPC. Contributed by David Taylor.

        Show
        ASF subversion and git services added a comment - Commit 1561874 from Doug Cutting in branch 'avro/trunk' [ https://svn.apache.org/r1561874 ] AVRO-1446 . C#: Correctly handle system errors in RPC. Contributed by David Taylor.
        Hide
        Doug Cutting added a comment -

        I committed this. Thanks, David!

        Show
        Doug Cutting added a comment - I committed this. Thanks, David!
        Doug Cutting made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in AvroJava #429 (See https://builds.apache.org/job/AvroJava/429/)
        AVRO-1446. C#: Correctly handle system errors in RPC. Contributed by David Taylor. (cutting: rev 1561874)

        • /avro/trunk/CHANGES.txt
        • /avro/trunk/lang/csharp/src/apache/ipc/Responder.cs
        • /avro/trunk/lang/csharp/src/apache/ipc/Specific/SpecificRequestor.cs
        • /avro/trunk/lang/csharp/src/apache/main/Protocol/Message.cs
        • /avro/trunk/lang/csharp/src/apache/test/Ipc/SocketServerWithCallbacksTest.cs
        Show
        Hudson added a comment - SUCCESS: Integrated in AvroJava #429 (See https://builds.apache.org/job/AvroJava/429/ ) AVRO-1446 . C#: Correctly handle system errors in RPC. Contributed by David Taylor. (cutting: rev 1561874) /avro/trunk/CHANGES.txt /avro/trunk/lang/csharp/src/apache/ipc/Responder.cs /avro/trunk/lang/csharp/src/apache/ipc/Specific/SpecificRequestor.cs /avro/trunk/lang/csharp/src/apache/main/Protocol/Message.cs /avro/trunk/lang/csharp/src/apache/test/Ipc/SocketServerWithCallbacksTest.cs
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        50m 29s 1 Doug Cutting 24/Jan/14 22:38
        Patch Available Patch Available Resolved Resolved
        2d 23h 27m 1 Doug Cutting 27/Jan/14 22:06
        Resolved Resolved Closed Closed
        177d 22h 10m 1 Doug Cutting 24/Jul/14 21:16

          People

          • Assignee:
            David Taylor
            Reporter:
            David Taylor
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development