Uploaded image for project: 'Avro'
  1. Avro
  2. AVRO-142

Removing unused fields, constructors, and imports

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: java
    • Labels:
      None

      Description

      The patch to follow removes some unused fields. I've been setting up Eclipse to work on Avro (patch forthcoming), and Eclipse is perhaps unreasonably whiny about these things, but there were so few, that it seemed harmless to fix them.

      DataFileReader had a "count" field, which was never read (only assigned), so I've deleted it.

      Several classes had LOG fields that were never used; I deleted them.

      TestCompare had a handful of unused imports; just deleted them.

        Attachments

        1. AVRO-142.patch.text
          9 kB
          Philip Zeyliger
        2. AVRO-142.patch.v2.txt
          33 kB
          Philip Zeyliger
        3. AVRO-142.patch.v3.txt
          33 kB
          Philip Zeyliger

          Activity

            People

            • Assignee:
              philip Philip Zeyliger
              Reporter:
              philip Philip Zeyliger
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: