Avro
  1. Avro
  2. AVRO-1351

Java: SortedKeyValueFile should support data models beyond generic

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.5
    • Component/s: None
    • Labels:
      None

      Description

      SortedKeyValueFile always uses GenericDatumReader and GenericDatumWriter, so it cannot contain data using specific, reflect or other data models.

      1. AVRO-1351.patch
        12 kB
        Doug Cutting
      2. AVRO-1351.patch
        16 kB
        Doug Cutting

        Activity

        Hide
        Hudson added a comment -

        Integrated in AvroJava #382 (See https://builds.apache.org/job/AvroJava/382/)
        AVRO-1351. Extend SortedKeyValueFile to support data models besides generic. (Revision 1501579)

        Result = FAILURE
        cutting :
        Files :

        • /avro/trunk/CHANGES.txt
        • /avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java
        • /avro/trunk/lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectData.java
        • /avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificData.java
        • /avro/trunk/lang/java/mapred/src/main/java/org/apache/avro/hadoop/file/SortedKeyValueFile.java
        • /avro/trunk/lang/java/mapred/src/test/java/org/apache/avro/hadoop/file/TestSortedKeyValueFile.java
        • /avro/trunk/lang/java/protobuf/src/main/java/org/apache/avro/protobuf/ProtobufData.java
        • /avro/trunk/lang/java/thrift/src/main/java/org/apache/avro/thrift/ThriftData.java
        Show
        Hudson added a comment - Integrated in AvroJava #382 (See https://builds.apache.org/job/AvroJava/382/ ) AVRO-1351 . Extend SortedKeyValueFile to support data models besides generic. (Revision 1501579) Result = FAILURE cutting : Files : /avro/trunk/CHANGES.txt /avro/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java /avro/trunk/lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectData.java /avro/trunk/lang/java/avro/src/main/java/org/apache/avro/specific/SpecificData.java /avro/trunk/lang/java/mapred/src/main/java/org/apache/avro/hadoop/file/SortedKeyValueFile.java /avro/trunk/lang/java/mapred/src/test/java/org/apache/avro/hadoop/file/TestSortedKeyValueFile.java /avro/trunk/lang/java/protobuf/src/main/java/org/apache/avro/protobuf/ProtobufData.java /avro/trunk/lang/java/thrift/src/main/java/org/apache/avro/thrift/ThriftData.java
        Hide
        Doug Cutting added a comment -

        I committed this.

        Show
        Doug Cutting added a comment - I committed this.
        Hide
        ASF subversion and git services added a comment -

        Commit 1501579 from Doug Cutting
        [ https://svn.apache.org/r1501579 ]

        AVRO-1351. Extend SortedKeyValueFile to support data models besides generic.

        Show
        ASF subversion and git services added a comment - Commit 1501579 from Doug Cutting [ https://svn.apache.org/r1501579 ] AVRO-1351 . Extend SortedKeyValueFile to support data models besides generic.
        Hide
        Doug Cutting added a comment -

        I'll commit this soon unless there are objections.

        Show
        Doug Cutting added a comment - I'll commit this soon unless there are objections.
        Hide
        Doug Cutting added a comment -

        Here's a version that includes tests.

        Show
        Doug Cutting added a comment - Here's a version that includes tests.
        Hide
        Doug Cutting added a comment -

        Here's a patch that should fix this, although I've not yet tested it. Unit tests are still needed.

        Show
        Doug Cutting added a comment - Here's a patch that should fix this, although I've not yet tested it. Unit tests are still needed.

          People

          • Assignee:
            Doug Cutting
            Reporter:
            Doug Cutting
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development