Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0
    • Component/s: java
    • Labels:
      None

      Description

      A report for mvn versions:display-property-updates on trunk –

      [INFO] The following version properties are referencing the newest available version:
      [INFO]   ${jetty.version} ............................................. 6.1.26
      [INFO]   ${javacc-plugin.version} ........................................ 2.6
      [INFO]   ${velocity.version} ............................................. 1.7
      [INFO]   ${exec-plugin.version} ........................................ 1.2.1
      [INFO] The following version property updates are available:
      [INFO]   ${jackson.version} .................................. 1.8.8 -> 1.9.11
      [INFO]   ${source-plugin.version} ............................. 2.1.2 -> 2.2.1
      [INFO]   ${jar-plugin.version} .................................. 2.3.2 -> 2.4
      [INFO]   ${snappy.version} ................................. 1.0.5 -> 1.1.0-M3
      [INFO]   ${checkstyle-plugin.version} ............................ 2.8 -> 2.10
      [INFO]   ${hadoop1.version} .............................. 0.20.205.0 -> 1.1.2
      [INFO]   ${commons-compress.version} ............................ 1.4.1 -> 1.5
      [INFO]   ${plugin-plugin.version} ................................. 2.9 -> 3.2
      [INFO]   ${javadoc-plugin.version} ................................ 2.8 -> 2.9
      [INFO]   ${compiler-plugin.version} ............................. 2.3.2 -> 3.1
      [INFO]   ${jopt-simple.version} ................................... 4.1 -> 4.4
      [INFO]   ${surefire-plugin.version} ........................... 2.12 -> 2.14.1
      [INFO]   ${paranamer.version} ................................... 2.3 -> 2.5.2
      [INFO]   ${netty.version} ........................ 3.4.0.Final -> 4.0.0.Alpha8
      [INFO]   ${slf4j.version} ..................................... 1.6.4 -> 1.7.5
      [INFO]   ${shade-plugin.version} .................................. 1.5 -> 2.1
      [INFO]   ${junit.version} ....................................... 4.10 -> 4.11
      

      Consider upgrades for these as well as the Apache parent and build plugins.

      1. AVRO-1334.patch
        231 kB
        Doug Cutting
      2. AVRO-1334.patch
        12 kB
        Scott Carey

        Issue Links

          Activity

          Hide
          Scott Carey added a comment -

          Jackson requires an upgrade because there is currently a bug in Avro due to it (I ran into it in AVRO-1325, unit tests there fail without Jackson 1.9.12.

          Hadoop1: I am not sure what the best version here is – 0.20.205 feels a bit old. Suggestions?

          Jopt-simple is a low risk update.
          Paranamer is a low risk update (only a handful of bugfixes).
          sfl4j looks safe to update (performance improvements, bug fixes, and now compiled against Java 1.5 target).
          Junit is safe to update.

          netty – netty 3.6.6.GA should be compatible (see http://netty.io/news/index.html) and has many fixes / enhancements.
          (an aside, netty now supports HTTP, so perhaps we can drop the ancient Jetty version we use and rely on netty for both raw and http to simplify things later?)

          The remainder are plugin updates, which are generally safe since testing them is easy to cover.

          I'll submit a patch with the updates shortly.

          Show
          Scott Carey added a comment - Jackson requires an upgrade because there is currently a bug in Avro due to it (I ran into it in AVRO-1325 , unit tests there fail without Jackson 1.9.12. Hadoop1: I am not sure what the best version here is – 0.20.205 feels a bit old. Suggestions? Jopt-simple is a low risk update. Paranamer is a low risk update (only a handful of bugfixes). sfl4j looks safe to update (performance improvements, bug fixes, and now compiled against Java 1.5 target). Junit is safe to update. netty – netty 3.6.6.GA should be compatible (see http://netty.io/news/index.html ) and has many fixes / enhancements. (an aside, netty now supports HTTP, so perhaps we can drop the ancient Jetty version we use and rely on netty for both raw and http to simplify things later?) The remainder are plugin updates, which are generally safe since testing them is easy to cover. I'll submit a patch with the updates shortly.
          Hide
          Scott Carey added a comment -

          This patch updates versions of plugins and many dependencies. Of note:

          Netty version 3.6.6 was causing a deadlock in unit tests every time for me in TestNettyServerWithCallbacks (mac, java7). All versions of 3.4.x and 3.5.x including the current version hang about 15% of the time in TestNettyTransceiverWhenServerStops. I upgraded to the latest in the 3.5.x series.

          I cleaned up some version consistency in a few places, and the JUnit/Hamcrest relationship has changed a little.

          The newer maven plugin versions triggered deprecations in the maven plugins, so I updated those trivially.

          Show
          Scott Carey added a comment - This patch updates versions of plugins and many dependencies. Of note: Netty version 3.6.6 was causing a deadlock in unit tests every time for me in TestNettyServerWithCallbacks (mac, java7). All versions of 3.4.x and 3.5.x including the current version hang about 15% of the time in TestNettyTransceiverWhenServerStops. I upgraded to the latest in the 3.5.x series. I cleaned up some version consistency in a few places, and the JUnit/Hamcrest relationship has changed a little. The newer maven plugin versions triggered deprecations in the maven plugins, so I updated those trivially.
          Hide
          Scott Carey added a comment -

          And lastly, the TestIDL had to be changed since the Jackson upgrade changed the whitespace in pretty print slightly (an empty array is now "[]" instead of "[\n]", so I made the test insensitive to whitespace.

          Show
          Scott Carey added a comment - And lastly, the TestIDL had to be changed since the Jackson upgrade changed the whitespace in pretty print slightly (an empty array is now "[]" instead of " [\n] ", so I made the test insensitive to whitespace.
          Hide
          Scott Carey added a comment -

          Dependencies I did not update that I defer to the expertise of others (a.k.a. I have no idea what the best thing to do is).

          hadoop1
          hadoop2
          thrift
          protobuf

          Show
          Scott Carey added a comment - Dependencies I did not update that I defer to the expertise of others (a.k.a. I have no idea what the best thing to do is). hadoop1 hadoop2 thrift protobuf
          Hide
          Hudson added a comment -

          Integrated in AvroJava #375 (See https://builds.apache.org/job/AvroJava/375/)
          AVRO-1334. Java: Upgrade snappy-java dependency to 1.0.5 (Revision 1484656)

          Result = SUCCESS
          scottcarey :
          Files :

          • /avro/trunk/CHANGES.txt
          • /avro/trunk/lang/java/pom.xml
          Show
          Hudson added a comment - Integrated in AvroJava #375 (See https://builds.apache.org/job/AvroJava/375/ ) AVRO-1334 . Java: Upgrade snappy-java dependency to 1.0.5 (Revision 1484656) Result = SUCCESS scottcarey : Files : /avro/trunk/CHANGES.txt /avro/trunk/lang/java/pom.xml
          Hide
          Doug Cutting added a comment -

          There was a commit against this issue, but it only updated snappy. Do you want to get the rest of these updates into 1.7.5? Or should we slip this to 1.8.0?

          Show
          Doug Cutting added a comment - There was a commit against this issue, but it only updated snappy. Do you want to get the rest of these updates into 1.7.5? Or should we slip this to 1.8.0?
          Hide
          Scott Carey added a comment -

          I think the snappy issue was separate (or should have been as I opened a differnt JIRA for that).

          Jackson has been updated to the latest 1.9.x because of a bug found while thoroughly testing the new schema builder API, as part of that ticket.

          Show
          Scott Carey added a comment - I think the snappy issue was separate (or should have been as I opened a differnt JIRA for that). Jackson has been updated to the latest 1.9.x because of a bug found while thoroughly testing the new schema builder API, as part of that ticket.
          Hide
          Scott Carey added a comment -

          Most of the other version changes relate to the build plugins. It would be useful to move up to requiring maven 3 and use all of the latest build plugins there, but that can wait until after 1.7.5.

          My other comments from May apply, but can wait until after 1.7.5. I'd rather get a release out and work on another than delay any longer.

          Show
          Scott Carey added a comment - Most of the other version changes relate to the build plugins. It would be useful to move up to requiring maven 3 and use all of the latest build plugins there, but that can wait until after 1.7.5. My other comments from May apply, but can wait until after 1.7.5. I'd rather get a release out and work on another than delay any longer.
          Hide
          Doug Cutting added a comment -

          Here's an updated version of this patch. It also updates protobuf, thrift, & hadoop to current versions. All tests pass for me.

          Here's the output of 'mvn versions:display-property-updates':

          [INFO] The following version properties are referencing the newest available version:
          [INFO]   ${jackson.version} ........................................... 1.9.13
          [INFO]   ${jetty.version} ............................................. 6.1.26
          [INFO]   ${jar-plugin.version} ........................................... 2.5
          [INFO]   ${source-plugin.version} ........................................ 2.3
          [INFO]   ${hamcrest.version} ............................................. 1.3
          [INFO]   ${bundle-plugin-version} ...................................... 2.5.3
          [INFO]   ${plugin-plugin.version} ........................................ 3.3
          [INFO]   ${javadoc-plugin.version} ..................................... 2.9.1
          [INFO]   ${compiler-plugin.version} ...................................... 3.1
          [INFO]   ${velocity.version} ............................................. 1.7
          [INFO]   ${hadoop2.version} ............................................ 2.5.0
          [INFO]   ${easymock.version} ............................................. 3.2
          [INFO]   ${commons-httpclient.version} ................................... 3.1
          [INFO]   ${paranamer.version} ............................................ 2.7
          [INFO]   ${exec-plugin.version} ........................................ 1.3.2
          [INFO]   ${snappy.version} ........................................... 1.1.1.3
          [INFO]   ${hadoop1.version} ............................................ 1.2.1
          [INFO]   ${checkstyle-plugin.version} ................................. 2.12.1
          [INFO]   ${commons-compress.version} ................................... 1.8.1
          [INFO]   ${javacc-plugin.version} ........................................ 2.6
          [INFO]   ${jopt-simple.version} .......................................... 4.7
          [INFO]   ${tukaani.version} .............................................. 1.5
          [INFO]   ${surefire-plugin.version} ..................................... 2.17
          [INFO]   ${slf4j.version} .............................................. 1.7.7
          [INFO] The following version property updates are available:
          [INFO]   ${netty.version} ....................... 3.5.13.Final -> 4.0.0.Alpha8
          [INFO]   ${junit.version} ................................ 4.11 -> 4.12-beta-1
          [INFO]   ${shade-plugin.version} ................................ 1.7.1 -> 2.3
          

          If there are no objections, I'll commit this soon.

          Show
          Doug Cutting added a comment - Here's an updated version of this patch. It also updates protobuf, thrift, & hadoop to current versions. All tests pass for me. Here's the output of 'mvn versions:display-property-updates': [INFO] The following version properties are referencing the newest available version: [INFO] ${jackson.version} ........................................... 1.9.13 [INFO] ${jetty.version} ............................................. 6.1.26 [INFO] ${jar-plugin.version} ........................................... 2.5 [INFO] ${source-plugin.version} ........................................ 2.3 [INFO] ${hamcrest.version} ............................................. 1.3 [INFO] ${bundle-plugin-version} ...................................... 2.5.3 [INFO] ${plugin-plugin.version} ........................................ 3.3 [INFO] ${javadoc-plugin.version} ..................................... 2.9.1 [INFO] ${compiler-plugin.version} ...................................... 3.1 [INFO] ${velocity.version} ............................................. 1.7 [INFO] ${hadoop2.version} ............................................ 2.5.0 [INFO] ${easymock.version} ............................................. 3.2 [INFO] ${commons-httpclient.version} ................................... 3.1 [INFO] ${paranamer.version} ............................................ 2.7 [INFO] ${exec-plugin.version} ........................................ 1.3.2 [INFO] ${snappy.version} ........................................... 1.1.1.3 [INFO] ${hadoop1.version} ............................................ 1.2.1 [INFO] ${checkstyle-plugin.version} ................................. 2.12.1 [INFO] ${commons-compress.version} ................................... 1.8.1 [INFO] ${javacc-plugin.version} ........................................ 2.6 [INFO] ${jopt-simple.version} .......................................... 4.7 [INFO] ${tukaani.version} .............................................. 1.5 [INFO] ${surefire-plugin.version} ..................................... 2.17 [INFO] ${slf4j.version} .............................................. 1.7.7 [INFO] The following version property updates are available: [INFO] ${netty.version} ....................... 3.5.13.Final -> 4.0.0.Alpha8 [INFO] ${junit.version} ................................ 4.11 -> 4.12-beta-1 [INFO] ${shade-plugin.version} ................................ 1.7.1 -> 2.3 If there are no objections, I'll commit this soon.
          Hide
          ASF subversion and git services added a comment -

          Commit 1626912 from Doug Cutting in branch 'avro/trunk'
          [ https://svn.apache.org/r1626912 ]

          AVRO-1334. Java: Update versions of many dependencies.

          Show
          ASF subversion and git services added a comment - Commit 1626912 from Doug Cutting in branch 'avro/trunk' [ https://svn.apache.org/r1626912 ] AVRO-1334 . Java: Update versions of many dependencies.
          Hide
          Doug Cutting added a comment -

          I committed this.

          Show
          Doug Cutting added a comment - I committed this.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in AvroJava #481 (See https://builds.apache.org/job/AvroJava/481/)
          AVRO-1334. Java: Update versions of many dependencies. (cutting: rev 1626912)

          • /avro/trunk/CHANGES.txt
          • /avro/trunk/lang/java/avro/pom.xml
          • /avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/ipc/TestNettyTransceiverWhenServerStops.java
          • /avro/trunk/lang/java/mapred/pom.xml
          • /avro/trunk/lang/java/mapred/src/test/java/org/apache/avro/hadoop/util/TestAvroCharSequenceComparator.java
          • /avro/trunk/lang/java/maven-plugin/pom.xml
          • /avro/trunk/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java
          • /avro/trunk/lang/java/pom.xml
          • /avro/trunk/lang/java/protobuf/src/test/java/org/apache/avro/protobuf/Test.java
          • /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/E.java
          • /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Error.java
          • /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Foo.java
          • /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/FooOrBar.java
          • /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Nested.java
          • /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Test.java
          • /avro/trunk/lang/java/tools/pom.xml
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/BinaryFragmentToJsonTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/CatTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/CreateRandomFileTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/DataFileGetMetaTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/DataFileReadTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/DataFileWriteTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/FromTextTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/JsonToBinaryFragmentTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/RecodecTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/RpcReceiveTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/RpcSendTool.java
          • /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/ToTrevniTool.java
          • /avro/trunk/lang/java/trevni/avro/pom.xml
          • /avro/trunk/lang/java/trevni/core/pom.xml
          • /avro/trunk/lang/java/trevni/pom.xml
          • /avro/trunk/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in AvroJava #481 (See https://builds.apache.org/job/AvroJava/481/ ) AVRO-1334 . Java: Update versions of many dependencies. (cutting: rev 1626912) /avro/trunk/CHANGES.txt /avro/trunk/lang/java/avro/pom.xml /avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/ipc/TestNettyTransceiverWhenServerStops.java /avro/trunk/lang/java/mapred/pom.xml /avro/trunk/lang/java/mapred/src/test/java/org/apache/avro/hadoop/util/TestAvroCharSequenceComparator.java /avro/trunk/lang/java/maven-plugin/pom.xml /avro/trunk/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java /avro/trunk/lang/java/pom.xml /avro/trunk/lang/java/protobuf/src/test/java/org/apache/avro/protobuf/Test.java /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/E.java /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Error.java /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Foo.java /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/FooOrBar.java /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Nested.java /avro/trunk/lang/java/thrift/src/test/java/org/apache/avro/thrift/test/Test.java /avro/trunk/lang/java/tools/pom.xml /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/BinaryFragmentToJsonTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/CatTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/CreateRandomFileTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/DataFileGetMetaTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/DataFileReadTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/DataFileWriteTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/FromTextTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/JsonToBinaryFragmentTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/RecodecTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/RpcReceiveTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/RpcSendTool.java /avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/ToTrevniTool.java /avro/trunk/lang/java/trevni/avro/pom.xml /avro/trunk/lang/java/trevni/core/pom.xml /avro/trunk/lang/java/trevni/pom.xml /avro/trunk/pom.xml

            People

            • Assignee:
              Doug Cutting
              Reporter:
              Scott Carey
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development