Avro
  1. Avro
  2. AVRO-113

C++ version is using wrong endian for varints

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0
    • Component/s: c++
    • Labels:
      None

      Description

      I totally overlooked the wording in the spec that says least significant parts appear before more significant ones, and used the inverse convention.

      This was discovered when I compared to Java output (highlighting the absence of the interoperability tests for c++!).

      Here is a fix for the code. Interoperability tests should follow soon.

      1. AVRO-113.patch
        2 kB
        Scott Banachowski

        Activity

        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Doug Cutting made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 1.2.0 [ 12314242 ]
        Resolution Fixed [ 1 ]
        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Scott!

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Scott!
        Doug Cutting made changes -
        Assignee Scott Banachowski [ sbanacho ]
        Scott Banachowski made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Scott Banachowski made changes -
        Field Original Value New Value
        Attachment AVRO-113.patch [ 12418971 ]
        Scott Banachowski created issue -

          People

          • Assignee:
            Scott Banachowski
            Reporter:
            Scott Banachowski
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development