Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-1079

C++ Generator, improve include guard generation

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.6.3, 1.7.0
    • 1.7.0
    • c++
    • None

    Description

      We integrated avro into our cmake build system. So we have json -> c++ header build step which is quite similar to the QT moc-compiler. This build step will overwrite the target header-files if the json schema file was modified or when the generated header files are different.
      In addition to that we want to put the generated header files under version control.
      However, the generated include-guards contains some random parts. This random part troubles the version control system. In addition to that this random part leads to unnecessary rebuilds as cmake 'thinks' important files have been changed and triggers a rebuild of the corresponding dependencies.

      Suggestion:
      Add an additional command line parameter to either switch off the random part of the string, or to take a string from the command line and use this as include guard.

      Attachments

        1. AVRO-1079.patch
          3 kB
          Thiruvalluvan M. G.

        Activity

          People

            thiru_mg Thiruvalluvan M. G.
            nurf Falk.Tristram@cae.de
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 5h
                5h
                Remaining:
                Remaining Estimate - 5h
                5h
                Logged:
                Time Spent - Not Specified
                Not Specified