Avro
  1. Avro
  2. AVRO-1074

Suggested optimization for Utf8.length()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.3
    • Fix Version/s: 1.7.0
    • Component/s: java
    • Labels:
      None

      Description

      Wanted to suggest a small optimization. It is quite common for applications to do a quick check (along with null-ness) for 0-length of string-typed fields. Today's Utf8.length() implementation is:

      return toString().length;

      I believe this could easily get optimized to return this instead:

      return length == 0 ? 0 : toString().length();

      Thus avoiding the need to create the string representation for this common use case (and scenario).

      1. AVRO-1074.patch
        0.5 kB
        Doug Cutting

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Doug Cutting
            Reporter:
            Hernan Otero
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development