[AVRO-1065] NodeRecord::isValid() treats records with no fields as invalid

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.3
• Fix Version/s: 1.7.0
• Component/s: c++
• Tags: c++
• Assignee: Thiruvalluvan M. G.
• Reporter: Keh-Li Sheng
• Created: 18/Apr/12 20:52
• Updated: 25/Sep/12 21:24
• Resolved: 13/May/12 17:28

Description

Implementation of NodeRecord in NodeImpl.hh requires that a record have at least 1 field in it but this is not required as per the specification at http://avro.apache.org/docs/1.6.3/spec.html#schema_record. Either remove the condition or update the spec. This only seems to be a quirk in c++.

NodeImpl.hh

class AVRO_DECL NodeRecord : public NodeImplRecord
{

    ...

    bool isValid() const {
        return (
                (nameAttribute_.size() == 1) && 
                (leafAttributes_.size() > 0) &&
                (leafAttributes_.size() == leafNameAttributes_.size())
               );
    }
}