Avro
  1. Avro
  2. AVRO-1056

ReflectData thinks the instance of a java.util.Map as a record type

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.3
    • Fix Version/s: 1.7.0
    • Component/s: java
    • Labels:
      None
    • Environment:

      MacOSX 10.7.2
      Eclipse 3.7
      JDK1.6

      Description

      the avro's java api org.apache.avro.reflect.ReflectData.isRecord() should add the following code.

      if (datum instanceof Map) return false;

      1. AVRO-1056.patch
        1 kB
        Doug Cutting
      2. ReflectData.java.patch
        0.5 kB
        Kevin Zhao

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          4d 7h 1m 1 Kevin Zhao 17/Apr/12 10:01
          Patch Available Patch Available Resolved Resolved
          30d 12h 16m 1 Doug Cutting 17/May/12 22:17
          Resolved Resolved Closed Closed
          24d 22h 44m 1 Doug Cutting 11/Jun/12 21:01
          Tom White made changes -
          Link This issue relates to AVRO-1525 [ AVRO-1525 ]
          Doug Cutting made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Doug Cutting made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Doug Cutting added a comment -

          I committed this.

          Show
          Doug Cutting added a comment - I committed this.
          Doug Cutting made changes -
          Attachment AVRO-1056.patch [ 12527709 ]
          Hide
          Doug Cutting added a comment -

          Here's a version of the patch that includes a test.

          I'll commit this soon unless someone objects.

          Show
          Doug Cutting added a comment - Here's a version of the patch that includes a test. I'll commit this soon unless someone objects.
          Doug Cutting made changes -
          Assignee Kevin Zhao [ kevinzhao ]
          Fix Version/s 1.7.0 [ 12318848 ]
          Fix Version/s 1.6.3 [ 12319869 ]
          Hide
          Doug Cutting added a comment -

          Patch looks good to me and existing tests pass with it applied.

          We should also add a test to TestReflect.java that fails without this patch but succeeds with it.

          Show
          Doug Cutting added a comment - Patch looks good to me and existing tests pass with it applied. We should also add a test to TestReflect.java that fails without this patch but succeeds with it.
          Hide
          Kevin Zhao added a comment -

          request for code reviewing~

          Show
          Kevin Zhao added a comment - request for code reviewing~
          Kevin Zhao made changes -
          Attachment ReflectData.java.patch [ 12522931 ]
          Kevin Zhao made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Kevin Zhao made changes -
          Attachment ReflectData.java.patch [ 12522932 ]
          Kevin Zhao made changes -
          Field Original Value New Value
          Attachment ReflectData.java.patch [ 12522931 ]
          Kevin Zhao created issue -

            People

            • Assignee:
              Kevin Zhao
              Reporter:
              Kevin Zhao
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development