[AVRO-1049] GenericData.Record#equals() does not return false when the schemas are not equal

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.6.0
• Fix Version/s: 1.7.0
• Component/s: java
• Assignee: Doug Cutting
• Reporter: Andrew Kenworthy
• Created: 23/Mar/12 13:20
• Updated: 11/Jun/12 20:01
• Resolved: 16/May/12 21:58

Description

GenericData.Record#equals() does not return false when the schemas are not equal: it currently only checks
the schema names as a performance optimization; this test code illustrates the issue:

@Test
public void test() {
   Schema schema1 = Schema.createRecord("test_record", null, "my.namespace", false);
   List<Field> fields1 = new ArrayList<Field>();
   fields1.add(new Field("attribute1", Schema.create(Schema.Type.STRING), null, null, Order.IGNORE));
   schema1.setFields(fields1);

   Schema schema2 = Schema.createRecord("test_record", null, "my.namespace", false);
   List<Field> fields2 = new ArrayList<Field>();
   fields2.add(new Field("attribute1", Schema.create(Schema.Type.STRING), null, null, Order.ASCENDING));
   schema2.setFields(fields2);

   GenericRecord record1 = new GenericData.Record(schema1);
   record1.put("attribute1", "1");

   GenericRecord record2 = new GenericData.Record(schema2);
   record2.put("attribute1", "2");

   System.out.println(record1.equals(record2)); // returns TRUE
   System.out.println(record2.equals(record1)); // returns FALSE
}

See also:

http://mail-archives.apache.org/mod_mbox/avro-user/201202.mbox/[e-mail]%3E