Avro
  1. Avro
  2. AVRO-1003

Invalid pkgconfig file when compiling without optional codecs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.1
    • Fix Version/s: 1.6.2
    • Component/s: c
    • Labels:
      None

      Description

      The codecs that were added in AVRO-957 (zlib and lzma) are optional. However, if you compile the C library with the required libraries being present, you get an invalid pkgconfig file:

      $ cat src/avro-c.pc
      Name: avro-c
      Description: C library for parsing Avro data
      Version: 1.6.2-SNAPSHOT
      URL: http://avro.apache.org/
      Libs: -L/usr/local/Cellar/avro-c/HEAD/lib -lavro
      Cflags: -I/usr/local/Cellar/avro-c/HEAD/include
      Requires: zlib @LZMA_PKG@
      

      (The @LZMA_PKG@ part is a substitution variable that wasn't substituted.)

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 21h 51m 1 Douglas Creager 26/Jan/12 14:00
        Resolved Resolved Closed Closed
        19d 10h 46m 1 Doug Cutting 15/Feb/12 00:46
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Douglas Creager made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.6.2 [ 12319074 ]
        Resolution Fixed [ 1 ]
        Hide
        Douglas Creager added a comment -

        Committed to SVN.

        Show
        Douglas Creager added a comment - Committed to SVN.
        Douglas Creager made changes -
        Field Original Value New Value
        Attachment 0001-AVRO-1003.-C-Only-include-pkg-config-requirements-fo.patch [ 12511681 ]
        Hide
        Douglas Creager added a comment -

        The variables aren't substituted if they have no values. So if any of the codec libraries is missing, we set the corresponding variable to "".

        Show
        Douglas Creager added a comment - The variables aren't substituted if they have no values. So if any of the codec libraries is missing, we set the corresponding variable to "".
        Douglas Creager created issue -

          People

          • Assignee:
            Douglas Creager
            Reporter:
            Douglas Creager
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development