[AURORA-756] startUpdate fails with "Instance count must be positive."

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.6.0
• Component/s: Scheduler
• Assignee: Maxim Khutornenko
• Reporter: Maxim Khutornenko
• Created: 26/Sep/14 01:34
• Updated: 28/Oct/14 22:37
• Resolved: 29/Sep/14 23:34

Description

When a noop update is requested (i.e. all instances are already in desired state), the UpdateFactory.newUpdate fails checkArgument validation in:

     checkArgument(
          !instructions.getDesiredState().getInstances().isEmpty(),
          "Instance count must be positive.");

Recommend fixing it with https://reviews.apache.org/r/25481, which replaces that validation with the one in SchedulerThriftInterface before any diff applied.