Uploaded image for project: 'Aurora'
  1. Aurora
  2. AURORA-1963

Structdump endpoint shows thrift metadata

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.19.0
    • 0.20.0
    • Scheduler
    • Devcluster VM

    • Patch

    Description

      The structdump endpoint changed the way it displays the task config. This change made some thrift internal metadata visible, such as __isset_bitfield on optionals fields and appending underscores on the names of other fields.

      For example, here is a fragment of a 0.19 structdump output:

                  "timestamp": 1514573549125,
                  "status": "RUNNING",
                  "scheduler": "ee5feaf3d8b1",
                  "__isset_bitfield": 1,
                  "optionals": [
                    "MESSAGE",
                    "SCHEDULER"
                  ]
      

      And here is the same fragment, but with 0.18 scheduler:

              Item[2] = 
                timestamp: 1514574966299
                status: RUNNING
                message: not set
                scheduler: "84611e03fe9e"
      

      As the structdump is the only way to get the full configuration of a task through the UI, it is inconvenient to have those fields and naming messing around.

      The issue seems to be caused by a change in the way data taken from thrift is converted to be pretty printed; by changing a thrift specific converter to a GSON serializer. The proposed fix is to backport the old converter and restore the old structdump style.

      The review of the change related to the issue is here
      The old pretty print utility used in 0.18 is here

      Attachments

        Activity

          People

            Unassigned Unassigned
            juanfresia Juan Manuel Fresia
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: