[AURORA-1730] Improve pystachio Logger schema

• Type: Task
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: Client, Executor
• Assignee: Unassigned
• Reporter: John Sirois
• Created: 01/Jul/16 19:51
• Updated: 01/Jul/16 19:51

Description

The current pystachio Logger schema is less than ideal, requiring a ~redundant mode and rotate fields. A plan was discussed in the context of AURORA-1724 in review https://reviews.apache.org/r/49399/ that would end us at something like:

class Standard(Struct):
  pass

class Rotate(Struct):
  log_size = Default(Integer, 100*MB)
  backups = Default(Integer, 5)

class Logger(Struct):
  destination = Default(LoggerDestination, LoggerDestination('file'))
  mode = Default(Choice(Standard, Rotate), Standard())

This will require a deprecation period though with something like:

Rotate = RotatePolicy

class Logger(Struct):
  destination = Default(LoggerDestination, LoggerDestination('file'))
  mode = Default(Choice(LoggerMode, Standard, Rotate), Standard())
  rotate = RotatePolicy

Issue Links

• relates to: AURORA-1724 Thermos runner fails if log rotation is enabled