[AURORA-1650] I* entity objects have incorrect isSet* methods for collection types

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: Build, Scheduler
• Assignee: John Sirois
• Reporter: John Sirois
• Created: 24/Mar/16 14:03
• Updated: 12/Apr/16 13:58
• Resolved: 03/Apr/16 13:15

Description

For example, in ITaskQuery the taskIds set is populated like so:

this.taskIds = wrapped.isSetTaskIds()
        ? ImmutableSet.copyOf(wrapped.getTaskIds())
        : ImmutableSet.of();

And the isSet impl looks like so:

public boolean isSetTaskIds() {
  return taskIds != null;
}

So isSet for collections will always return true. It seems the generated isSet methods should only return true for non-empty collections or else these isSet methods should be eliminated altogether.

Issue Links

• is related to: AURORA-1651 I* entity objects are lossy for primitive isSet-ness
• is related to: AURORA-1476 TaskConfig dedupe routine does not handle null fields properly