Uploaded image for project: 'Aurora'
  1. Aurora
  2. AURORA-1581

Consider removing unused client updater RPCs

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.13.0
    • Scheduler
    • None

    Description

      We have a few thrift RPCs left after client updater removal that are no longer in use. Consider deprecating and removing these to avoid bit rot:

      Response acquireLock(1: LockKey lockKey)
      Response releaseLock(1: Lock lock, 2: LockValidation validation)
      Response getLocks()
      

      In addition, Lock object should be dropped from the following RPCs:

      Response createJob(1: JobConfiguration description, 3: Lock lock)
      Response scheduleCronJob(1: JobConfiguration description, 3: Lock lock)
      Response descheduleCronJob(4: JobKey job, 3: Lock lock)
      Response restartShards(5: JobKey job, 3: set<i32> shardIds, 6: Lock lock)
      Response addInstances(1: AddInstancesConfig config, 2: Lock lock)
      Response killTasks(1: TaskQuery query, 3: Lock lock)
      Response replaceCronTemplate(1: JobConfiguration config, 2: Lock lock)
      

      Attachments

        Issue Links

          Activity

            People

              wfarner Bill Farner
              maximk Maxim Khutornenko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: