[ATLAS-4658] base_client.py implementation is a bit messy

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 3.0.0, 2.4.0
• Component/s: atlas-intg
• Flags: Patch
• External issue URL: https://github.com/apache/atlas/pull/158/files

Language

Python

• Assignee: Maxim Martynov
• Reporter: Maxim Martynov
• Created: 17/Aug/22 11:55
• Updated: 07/Jun/23 08:16
• Resolved: 05/Jun/23 19:25

Description

atlas_client/client/base_client.py looks a bit messy:

https://github.com/apache/atlas/blob/c1daaa44c3833be31c006753a2cf2f6f2e476cdc/intg/src/main/python/apache_atlas/client/base_client.py#L79-L120

1. There is no need to make conditions with mapping between HTTPMethod enum values and corresponding requests.Session methods - there is a requests.Session.request method which accepts HTTP method as argument
2. There is no need to use elif in conditions if previous clauses are ended with return or raise statements
3. There is not need to use logger.isEnabledFor(logging.DEBUG) before calling logger.debug, this is already done in .debug method itself
4. Use logging, not print
5. {{logging.exception}} already shows full exception traceback, no need to explicitly show add it into a logging message

 

I've creates pull request with a fix for all these items:

https://github.com/apache/atlas/pull/158/files