[ATLAS-3863] Avoid re-evaluating tag propagation when deleting relationship (edge)

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.1.0
• Component/s: atlas-core
• Labels: classification tagpropagation
• Assignee: Sarath Subramanian
• Reporter: Sarath Subramanian
• Created: 24/Jun/20 19:55
• Updated: 29/Jun/20 22:29
• Resolved: 26/Jun/20 05:42

Description

Tag propagation is re-evaluated every time when a relationship (edge) is deleted.

Removal of propagated classifications is controlled at the assignment time to an entity:

 

• Remove propagation on entity delete - TRUE : 
  • Propagated classifications (to all downstream entities) will be removed when the source entity where the classification is originally assigned is deleted.

 

• Remove propagation on entity delete - FALSE : 
  • Propagated classifications (to all downstream entities) will not be removed when the          source entity where the classification is originally assigned is deleted.

 

There is no need to revaluate tag propagation during relationship (edge) deletion since removal of tag propagation depends on the above config

 

Significant performance improvement observed: 83% performance improvement seen.

Deleting a hive_table entity (with 44 columns and 16 propagated classifications)

{{Before patch : 279 secs (4 mins, 39 secs) }}

After patch  : 46.92 secs

 
 

Issue Links

• causes: ATLAS-3868 [Regression] removing a term-association doesn't remove classifications propagated from the term
• links to: Code review
• links to: Precommit