[ATLAS-2532] Advanced Search DSL: Improve Support for Numeric Data Types at Thresholds

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: trunk
• Fix Version/s: 1.0.0
• Component/s: atlas-core
• Assignee: Ashutosh Mestry
• Reporter: Ashutosh Mestry
• Due: 06/Apr/18
• Created: 05/Apr/18 05:45
• Updated: 12/Apr/18 19:44
• Resolved: 12/Apr/18 19:44

Description

Steps to duplicate the problem:

• Added this property to fs_path

                {

                    "name": "retention",

                    "typeName": "float",

                    "cardinality": "SINGLE",

                    "isIndexable": false,

                    "isOptional": true,

                    "isUnique": false

                }

• From Atlas WEB UI, add hdfs_path entity. Set the retention property to 3.4028235e+38.
• From Atlas WEB UI, Adanced Search use: hdfs_path where retention > 3.4028235e+38

Actual behavior: Error ‘Gremlin script execution failed: g.V().has('typeName', 'hdfs_path').has('hdfs_path.retention', gt(3.4028235e+38)).dedup().limit(25).toList()’ is displayed.

Expected behavior: Results should be displayed.

Root cause:

• Since the value is on threshold of max float, Gremlin converts this to BigDecimal and then does the comparision.

 

Fix:

• Using ‘f’ to suppress conversion to BigDecimal should address the problem.
• Using g.V().has('typeName', 'hdfs_path').has('hdfs_path.retention', lte(3.4028235e+38f)).dedup().limit(25).toList() addresses the problem.