[ATLAS-2037] Unit Test Failure: NotificationHookConsumerTest.testConsumersAreStoppedWhenInstanceBecomesPassive

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: trunk
• Fix Version/s: 0.8.1
• Component/s: atlas-core
• Assignee: Ashutosh Mestry
• Reporter: Ashutosh Mestry
• Due: 11/Aug/17
• Created: 09/Aug/17 20:35
• Updated: 17/May/18 04:55
• Resolved: 15/Aug/17 16:50

Description

Analysis

• The test has few mocks, but we don’t mock HookConsumer (derived from ShutdownableThread). Hence, the object needs be in line with its usage pattern.
• The ShutdownableThread has a CountdownLatch that is checked during shutdown.

In the test, the HookConsumer was not being started at all. This caused shutdownLatch (of type CountdownLatch) not to decrement, since no work was performed, but anticipating work is going to be done. The test thus ended up not getting completed, since the thread was in perpetual wait.

Solution
The HookConsumer should be used such that it is started and shutdown. So the test passes.

HookConsumer should check for shouldRun in shutdown method, so that the case where shutdown is called without start is handled.