[ATLAS-1666] Improve on Overly Broad Throws

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.8.1, 1.0.0
• Component/s: atlas-core
• Assignee: Ashutosh Mestry
• Reporter: Ashutosh Mestry
• Due: 19/Mar/17
• Created: 17/Mar/17 21:15
• Updated: 17/May/17 16:19
• Resolved: 19/Mar/17 18:17

Description

Methods in the following classes throws generic exception. This makes it hard for callers to effectively handle errors and recover. Although, this does not impact functionality. It would be valuable to improve on this.

Below is a files that have this pattern:
1. ActiveInstanceState.java
2. AbstractParam.java
3. QuickStart.java
4. SetupSteps.java
5. FalconHook.java
6. AtlasLdapAuthenticationProvider.java
7. FalconEventPublisher.java
8. AtlasADAuthenticationProvider.java
9. StormHook.java
10. FalconBridge.java
11. EmbeddedServer.java
12. StormTopologyUtil.java
13. SqoopHook.java
14. HiveHook.java
15. HiveMetaStoreBridge.java

General approach to refactoring would be define an error code in AtlasErrorCode and throw AtlasBaseException.

Issue Links

• links to: Code Review