[ARTEMIS-4189] NettyConnection.isSameTarget() should compare host names by IPs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 2.28.0
• Component/s: Broker
• Assignee: Howard Gao
• Reporter: Howard Gao
• Created: 01/Mar/23 02:42
• Updated: 06/Mar/23 08:53
• Resolved: 06/Mar/23 08:53

Description

The method just compares the host names using string equals. However when one host name is in IP form (like "10.7.2.2") it should try to resolve the addresses of the host name and make sure they are equal if one of the IP addresses matches. Otherwise it may return wrong comparison result.
Also when comparing localhost it should take care of the case where the host is absent from the transport configuration.

Issue Links

• relates to: ARTEMIS-4091 Make scaleDown target more deterministic
• links to: GitHub Pull Request #4385