[ARTEMIS-3922] Reducing contention on java.lang.Throwable#getOurStackTrace

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.24.0
• Fix Version/s: 2.25.0
• Assignee: Unassigned
• Reporter: Rico Neubauer
• Created: 04/Aug/22 07:13
• Updated: 30/Aug/22 21:05
• Resolved: 30/Aug/22 21:05

Description

This is a request for improvement rg. performance in a very specific case, but easy to accomplish.

Scenario

On certain contaier'ed Windows machines we have identified that java.lang.Throwable#getOurStackTrace along with java.lang.StackTraceElement#initStackTraceElements show up as a very expensive operations. The reason behind this is still unclear, but since the #getOurStackTrace is synchronized, it suffers even more when the native method #initStackTraceElements takes an unexpected long time.

This shows in thread-dumps in 2 locations for Artemis, where connection-creation is the more crucial one from my pov.

See attached threads.txt

Remedy

Fortunately the location where this gets used via Thread.currentThread().getStackTrace() is simple to replace, since the information needed could just get passed by caller.

Please see attached patch for my proposal.

Also available here as commit.

Can create a pull request as well.

Issue Links

• links to: GitHub Pull Request #4168