[ARTEMIS-3755] Mitigate NPE related to fail-back

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.22.0
• Assignee: Justin Bertram
• Reporter: Justin Bertram
• Created: 01/Apr/22 16:27
• Updated: 28/Apr/22 15:14
• Resolved: 28/Apr/22 15:14

Description

When configuring HA without a cluster-connection this NPE is thrown on the backup when the it becomes live:

INFO  [org.apache.activemq.artemis.core.server] AMQ221010: Backup Server is now live
ERROR [org.apache.activemq.artemis.core.server] AMQ224000: Failure in initialisation: java.lang.NullPointerException
    at org.apache.activemq.artemis.core.server.impl.SharedStoreBackupActivation$FailbackChecker.<init>(SharedStoreBackupActivation.java:256)
    at org.apache.activemq.artemis.core.server.impl.SharedStoreBackupActivation.startFailbackChecker(SharedStoreBackupActivation.java:248)
    at org.apache.activemq.artemis.core.server.impl.SharedStoreBackupActivation.run(SharedStoreBackupActivation.java:138)
    at org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$ActivationThread.run(ActiveMQServerImpl.java:4271)

HA without a cluster-connection is an invalid configuration, but it still shouldn't thrown an NPE. It should log a WARN instead.

Issue Links

• links to: GitHub Pull Request #4007