[ARTEMIS-2953] Page.finalize causing intermittent test failures

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.15.0
• Fix Version/s: 2.16.0
• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 15/Oct/20 10:54
• Updated: 03/Nov/20 01:17
• Resolved: 20/Oct/20 08:15

Description

I see two intermittent failures in the PR build jobs:

• PageTest.testDamagedPage:115->testDamagedPage:230 » IllegalState Is closed Error:
• PagingStoreImplTest.testConcurrentDepage:372->testConcurrentPaging:554 » IllegalState

 

Both seem to result from concurrent calls to close via the Page.finalize

finalize is hugely non deterministic, it should go. It may be that we need some more calls to close, lets see.

note: both those tests use FakeSequentialFileFactory but I don't think the problem is in that. 

Issue Links

• fixes: ARTEMIS-2874 PagingStoreImplTest.testConcurrentDepage fails a lot
• links to: GitHub Pull Request #3305