[ARTEMIS-2571] Remove unneccessary synchronization in ActiveMQServerImpl

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.10.1
• Fix Version/s: 2.12.0
• Component/s: Broker, Web Console
• Assignee: Unassigned
• Reporter: Sebastian T
• Created: 10/Dec/19 09:34
• Updated: 16/Apr/20 22:52
• Resolved: 22/Jan/20 21:33

Description

The ActiveMQServerImpl sessions field is a ConcurrentHashMap. Synchronizing on the ActiveMQServerImpl object to iterate over the map is not necessary. ActiveMQServerImpl#getSession, ActiveMQServerImpl#removeSession and ActiveMQServerImpl#createSession also work on the sessions field without synchronizing on the ActiveMQServerImpl.

Removing the synchronized keyword on the ActiveMQServerImpl#getSessions() methods e.g. improves loading of Connections view, especially when multiple administrators are using the UI.

Issue Links

• is related to: ARTEMIS-2570 Very slow loading of Connections view
• links to: GitHub Pull Request #2913