[ARTEMIS-2054] Artemis appears to never issue a JMS callback on error

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.6.2
• Component/s: Broker

Environment

I'm trying to use artemis for Brave (zipkin java tracer) testing of JMS 2.0 implementation.

I've noticed that the completion listener is never called on error. This might be a concern beyond my testing. Here's how I found this..

I traced the use of CompletionListener in org.apache.activemq.artemis.jms.client.ActiveMQMessageProducer. At what's currently line 515, it is used, but wrapped with a type that will never call the callback.

         if (completionListener != null) {
            clientProducer.send(address, coreMessage, new CompletionListenerWrapper(completionListener, jmsMessage, this));
         } else {
            clientProducer.send(address, coreMessage);
{{         }}}

Also, all catch blocks won't call the callback either. It is possible I missed something.

• Assignee: Unassigned
• Reporter: Adrian Cole
• Created: 27/Aug/18 03:21
• Updated: 17/Sep/18 22:10
• Resolved: 17/Sep/18 22:10

Description

I'm trying to use artemis for Brave (zipkin java tracer) testing of JMS 2.0 implementation.

I've noticed that the completion listener is never called on error. This might be a concern beyond my testing. Here's how I found this..

 

I traced the use of CompletionListener in org.apache.activemq.artemis.jms.client.ActiveMQMessageProducer. At what's currently line 515, it is used, but wrapped with a type that will never call the callback.

code
if (completionListener != null)

{ clientProducer.send(address, coreMessage, new CompletionListenerWrapper(completionListener, jmsMessage, this)); }

else

{ clientProducer.send(address, coreMessage); }

code

Also, all catch blocks won't call the callback either.

 

 

Issue Links

• duplicates: ARTEMIS-1545 JMS MessageProducer fails to expose exception on send when message is sent non-persistent, but not authorised