[ARTEMIS-1691] JMS Bridge: After the FailureHandler exits, a bridge cannot be started full functional anymore

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.4.0

Environment

WildFly Servers.

• Assignee: Justin Bertram
• Reporter: Markus F
• Created: 19/Feb/18 09:18
• Updated: 16/Apr/24 03:49

Description

Setup

JMSBridge on server a pulls messages from a remote server B.

failureRetryInterval = 1 sec

maxRetries = 1

To Reproduce

Restart the remote server (need to take more than one second.)

JMS Bridge prints out:

JMS Bridge unable to set up connections, bridge will be stopped

After the remote server is up again, start the bridge again.

JMS Bridge prints out:

Started JMS Bridge testbridge

 

Result:

The bridge is started, but does still not consume messages. 

Reason

In JMSBridgeImpl line 1624, the failed boolean parameter is checked. It is not set to true anywhere outside the failure handlers (FailureHandler and StartupFailureHandler) or on initial adding of the bridge.

But the FailureHandler has already exited. So the bridge will wait all time long for 500 ms in line 1626. 

Solution

I would add a

failed = false;

after line 403.

I don't know how the release process is handled here, if I can make a pull request or something like that, I will do, if it is needed.

Issue Links

• links to: GitHub Pull Request #4883