[ARTEMIS-1671] FindBugs: Null pointer dereferences (FORWARD_NULL) in AbstractJournalStorageManager.java

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 2.5.0
• Component/s: Broker
• External issue URL: https://scan.coverity.com/projects/apacheactivemqartemis
• External issue ID: 1465016
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 09/Feb/18 09:06
• Updated: 5 days ago 03:13
• Resolved: 5 days ago 03:13

Description

________________________________________________________________________________________________________
*** CID 1465016:  Null pointer dereferences  (FORWARD_NULL)
/activemq-artemis/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java: 1775 in org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.loadPreparedTransactions(org.apache.activemq.artemis.core.postoffice.PostOffice, org.apache.activemq.artemis.core.paging.PagingManager, org.apache.activemq.artemis.core.transaction.ResourceManager, java.util.Map, java.util.List, java.util.Map, java.util.Map, java.util.Set, org.apache.activemq.artemis.core.server.impl.JournalLoader)()
1769                       encoding.position.setRecordID(record.id);
1770
1771                       PageSubscription sub = locateSubscription(encoding.queueID, pageSubscriptions, queueInfos, pagingManager);
1772
1773                       if (sub != null) {
1774                          sub.reloadPreparedACK(tx, encoding.position);
>>>     CID 1465016:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing "null" to "PagedReferenceImpl", which dereferences it.
1775                          referencesToAck.add(new PagedReferenceImpl(encoding.position, null, sub));
1776                       } else {
1777                          ActiveMQServerLogger.LOGGER.journalCannotFindQueueReloadingACK(encoding.queueID);
1778                       }
1779                       break;
1780                    }

Issue Links

• Is contained by: ARTEMIS-1400 FindBugs warnings